search

fastmail / Ix

automatic generation of JMAP-style APIs
GNU General Public License v2.0
10 stars 5 forks source link

JMAP proc: be opaque in logs for unknown methods #117

Closed mmcclimon closed 5 years ago

mmcclimon commented 5 years ago

Right now, if you try to call a method that doesn't exist, we'll happily pass that through to record_call_info. This has led to some weird things in our stats processor, where we log status for every API call by type.

I'm not crazy about the way this is done, but it seems right to do it in Ix, and it's nice to have some way of logging that an unknown method was called. I suppose the other thing to do would just be not to record it if it was an unknown method, but that seems less good.

wolfsage commented 5 years ago

I don't like this because it doesn't let downstream apps know what the unknown method was that was called. I think it should be up to the downstream app to decide what to do with it

mmcclimon commented 5 years ago

Yeah, will do another way. Thanks.