search

fastmail / Ix

automatic generation of JMAP-style APIs
GNU General Public License v2.0
10 stars 5 forks source link

ix_get_list_updates - don't include rows that haven't changed #93

Closed wolfsage closed 7 years ago

wolfsage commented 7 years ago

If we're requesting updates since state 5, it doesn't make sense to include things that were last modified at state 5 or below.

rjbs commented 7 years ago

I think this is correct.

If you wanted a more rigorous test, it would be useful to make a new account and make it easy to see every change made, along with each state string, so you could then easily know exactly what should be added/removed in each possible change window, without ever worrying about other changes in the test. Possibly not worth doing just yet…