fastmail / authentication_milter

Email Authentication by SPF/DKIM/DMARC etc.
Other
121 stars 21 forks source link

frequent "Error parsing existing Authentication-Results header: unexpected token at .../Sanitize.pm" ? #132

Open pgnd opened 2 years ago

pgnd commented 2 years ago

running,

postconf mail_version
    mail_version = 3.7.3
perldoc Mail::Milter::Authentication | grep version
    version 3.20221006
perldoc Mail::AuthenticationResults | grep version
    version 2.20210915

where authentication_milter runs in SMTP mode,

...
"connection" : "inet:13001@127.0.0.1",
"protocol"  : "smtp",
"smtp" : {
    "sock_type"      : "inet",
    "sock_host"      : "127.0.0.1",
    "sock_port"      : "13002",
...

i notice in logs lots of these "unexpected token" errors,

xzegrep "Error parsing existing Authentication-Results" /var/log/postfix/*
    /var/log/postfix/postfix.log:2022-10-31T16:34:48.894462-04:00 mx auth-milter[17515]: 68EC8710EE0: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log:2022-11-03T10:16:26.149537-04:00 mx auth-milter[57659]: 5089DFF7AF5: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-22T08:41:53.537327-04:00 mx auth-milter[21209]: 90CFEF582D9: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-22T10:04:50.698366-04:00 mx auth-milter[21709]: 96EDC557783: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-22T10:08:16.097963-04:00 mx auth-milter[21709]: 07408B1E56F: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-22T10:08:48.869560-04:00 mx auth-milter[21709]: 9553A2A7568: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-22T13:02:21.074580-04:00 mx auth-milter[24515]: DC02033FB0B: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-22T13:03:56.212376-04:00 mx auth-milter[24515]: 24558D0D89B: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-22T13:04:20.029124-04:00 mx auth-milter[25961]: CBB0493C955: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-22T13:08:22.718071-04:00 mx auth-milter[25961]: D7F3D12C3E0: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-23T12:23:42.528556-04:00 mx auth-milter[42222]: 56ECEF86232: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-25T13:16:34.563293-04:00 mx auth-milter[20060]: 07E0FEF2967: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-08-28.1661659229.xz:2022-08-26T14:10:47.090196-04:00 mx auth-milter[36469]: A2B0FED3556: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-04.1662264028.xz:2022-08-29T10:58:08.670426-04:00 mx auth-milter[7061]: 2F703348A8D: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-04.1662264028.xz:2022-08-29T14:22:20.887090-04:00 mx auth-milter[7061]: C70F657EE35: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-04.1662264028.xz:2022-08-29T14:24:38.084955-04:00 mx auth-milter[7061]: 244B3E717CB: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-04.1662264028.xz:2022-08-31T10:51:47.477692-04:00 mx auth-milter[1275]: AA9ACB33A29: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-11.1662868813.xz:2022-09-09T10:53:16.548924-04:00 mx auth-milter[2068]: FF31F81A1D4: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-11.1662868813.xz:2022-09-09T11:59:02.169721-04:00 mx auth-milter[27548]: 06066B42B10: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-11.1662868813.xz:2022-09-09T11:59:06.094647-04:00 mx auth-milter[32072]: 2CDEDBC5531: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-11.1662868813.xz:2022-09-09T12:48:59.767220-04:00 mx auth-milter[36194]: 212AFE13BCA: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-11.1662868813.xz:2022-09-09T13:25:27.724977-04:00 mx auth-milter[38529]: 60C59646413: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-11.1662868813.xz:2022-09-09T14:36:18.746841-04:00 mx auth-milter[38529]: 351DA73B73D: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-18.1663473614.xz:2022-09-12T12:44:13.928952-04:00 mx auth-milter[7648]: BBD8CFC25A9: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-18.1663473614.xz:2022-09-12T12:44:16.298193-04:00 mx auth-milter[15580]: 0A7536F682C: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-18.1663473614.xz:2022-09-13T18:34:48.752871-04:00 mx auth-milter[27275]: 9E444AD5858: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-18.1663473614.xz:2022-09-14T11:54:18.638117-04:00 mx auth-milter[16240]: 7A9D1925063: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-18.1663473614.xz:2022-09-14T19:19:45.233662-04:00 mx auth-milter[43719]: B5968D954A9: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-18.1663473614.xz:2022-09-14T19:20:02.774937-04:00 mx auth-milter[54070]: AE24EAA8B75: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-18.1663473614.xz:2022-09-16T13:39:12.846368-04:00 mx auth-milter[16230]: 2257A38FCE7: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-25.1664078417.xz:2022-09-18T17:29:18.834628-04:00 mx auth-milter[9177]: 0FE2A87143D: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-09-25.1664078417.xz:2022-09-23T14:47:41.737315-04:00 mx auth-milter[17873]: A569D1FC448: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-02.1664683222.xz:2022-09-27T11:35:59.071332-04:00 mx auth-milter[1267]: 8269C9F3A02: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-16.1665892800.xz:2022-10-12T16:49:15.949376-04:00 mx auth-milter[55103]: 941068380E5: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-16.1665892800.xz:2022-10-14T15:21:47.241173-04:00 mx auth-milter[50437]: F17C7B363F8: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-23.1666497627.xz:2022-10-19T16:15:55.156844-04:00 mx auth-milter[1257]: 05E88460520: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-23.1666497627.xz:2022-10-20T10:58:28.040895-04:00 mx auth-milter[54766]: 3D6854E253F: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-24T12:44:26.502992-04:00 mx auth-milter[55576]: B543C16ABAD: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-24T12:45:30.407654-04:00 mx auth-milter[57304]: FB2B62C80F6: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-24T12:58:11.491135-04:00 mx auth-milter[57325]: C14B60A68ED: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-26T07:40:11.421695-04:00 mx auth-milter[19755]: 0FD2282B1A3: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-26T07:40:20.095785-04:00 mx auth-milter[25725]: 260060E06CB: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-26T10:44:56.512599-04:00 mx auth-milter[25776]: 7E1E37D8E28: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-27T14:18:27.747462-04:00 mx auth-milter[39932]: 790DB91AE64: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-27T14:18:27.975851-04:00 mx auth-milter[46515]: 92324DF1886: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-27T14:18:28.721956-04:00 mx auth-milter[46516]: 6D2AFA9A65E: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>
    /var/log/postfix/postfix.log.2022-10-30.1667102429:2022-10-27T14:18:29.183217-04:00 mx auth-milter[46529]: E0171B37D5C: ERROR: Error parsing existing Authentication-Results header: unexpected token at /usr/local/share/perl5/5.34/Mail/Milter/Authentication/Handler/Sanitize.pm line 129.<LF>

where,

https://github.com/fastmail/authentication_milter/blob/master/lib/Mail/Milter/Authentication/Handler/Sanitize.pm#L129

seems to be involved.

Known issue? Or, what add'l info/tests are needed here to track it down?

pedrinimm commented 2 years ago

In order to know if this is a known issue, It would be useful if you could provide a sample of the authentication header that is actually been parsed and it is trggering this error.

marcbradshaw commented 2 years ago

An existing Authentication-Results header could not be parsed, It will be present in the resulting message with a modified header name. I think the best change here is to update the logging to show the header that could not be parsed.