search

fastobo / fastobo-py

Faultless AST for Open Biomedical Ontologies in Python.
http://fastobo.readthedocs.io
MIT License
24 stars 4 forks source link

Installation fails on older Mac OSX versions #144

Closed ambrosejcarr closed 4 years ago

ambrosejcarr commented 4 years ago

Hello, thank you for building this tool! Our cellxgene application depends on fastobo, and we're running into issues when our users are attempting to install cellxgene on old versions of OS X (e.g. 10.12). That version does not ship with a rust compiler, so our installation fails.

Would you be able to build wheels for older versions of OSX? We believe that should solve the issue we're seeing. The pypi standard appears to be to support versions from 10.9 to present.

Thanks!

cc @mckinsel @maniarathi

althonos commented 4 years ago

Hi @ambrosejcarr ,

glad this library is of use to some people, I made it simple and easy-to-use to broaden the audience of ontology consumers :smiley:

Currently I am building wheels for OSX using the default Travis-CI OSX image, which is Xcode 9.4.1 / macOS 10.13. I'll try to see if it's feasible to use the lowest available version , but I think it only supports macOS 10.11 onward.

Other option I'll try is to have a build script that downloads the Rust compiler locally if not available, so that users without a Rust compiler installed manually can still build from source on their local platform.

althonos commented 4 years ago

v0.9.1 now builds the OSX wheels with XCode 7.3, which should increase support of older versions. I also updated the setup script so that, if a wheel cannot be found and compilation from source is attempted, a minimal Rust compiler is used if none is available on the host machine.

ambrosejcarr commented 4 years ago

Thank you! We'll update our dependencies, check that our user's installation problems are resolved, and report back.

On Sat, Aug 15, 2020 at 10:46 AM Martin Larralde notifications@github.com wrote:

v0.9.1 now builds the OSX wheels with XCode 7.3, which should increase support of older versions. I also updated the setup script so that, if a wheel cannot be found and compilation from source is attempted, a minimal Rust compiler is used if none is available on the host machine.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fastobo/fastobo-py/issues/144#issuecomment-674406890, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABH7C4DFHLTOAY6BBPKUY7TSA2NTRANCNFSM4P7OUWBA .

mckinsel commented 4 years ago

Just wanted to confirm that this resolved the issue for our user. Thanks very much for the super fast fix @althonos!

althonos commented 4 years ago

Great, thanks!