odidev commented 2 years ago

Added aarch64 wheel build support. Related to https://github.com/fastobo/fastobo-py/issues/245, @althonos Could you please review this PR?

althonos commented 2 years ago

@odidev : I allowed you to run the GH actions, you should be able to test your changes now.

odidev commented 2 years ago

I’m facing the following Assertion Error on running tests.

FAIL: load_graph (fastobo) 
Doctest: fastobo.load_graph 
---------------------------------------------------------------------- 
Traceback (most recent call last): 
  File "/opt/python/cp37-cp37m/lib/python3.7/doctest.py", line 2204, in runTest 
    raise self.failureException(self.format_failure(new.getvalue())) 
AssertionError: Failed doctest test for fastobo.load_graph 
  File "/ws/fastobo.cpython-37m-aarch64-linux-gnu.so", line unknown line number, in load_graph 

---------------------------------------------------------------------- 
File "/ws/fastobo.cpython-37m-aarch64-linux-gnu.so", line ?, in fastobo.load_graph 
Failed example: 
    doc[0] 
Expected:
    TermFrame(PrefixedIdent('BFO', '0000002')) 
Got: 
    TermFrame(PrefixedIdent('BFO', '0000001')) 

---------------------------------------------------------------------- 

Ran 125 tests in 10.934s

FAILED (failures=1, expected failures=3)

Also this error is seen in x86. Is it an expected error? Could you please have a look?

althonos commented 2 years ago

@odidev : this was an issue with one of the doctests failing, I have pushed a fix to the main branch, you can pull from that and it should fix it.

odidev commented 2 years ago

Done.

codecov[bot] commented 2 years ago

Codecov Report

Merging #246 (755bc19) into master (a01bdf0) will increase coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   34.69%   34.71%   +0.02%     
==========================================
  Files          24       24              
  Lines        3678     3678              
==========================================
+ Hits         1276     1277       +1     
+ Misses       2402     2401       -1

Impacted Files	Coverage Δ
src/py/mod.rs	`76.00% <0.00%> (-2.00%)`	:arrow_down:
src/py/id.rs	`59.48% <0.00%> (-0.52%)`	:arrow_down:
src/py/term/clause.rs	`27.80% <0.00%> (-0.17%)`	:arrow_down:
src/py/typedef/clause.rs	`11.95% <0.00%> (-0.10%)`	:arrow_down:
src/py/pv.rs	`69.91% <0.00%> (+0.81%)`	:arrow_up:
src/py/doc.rs	`78.66% <0.00%> (+1.33%)`	:arrow_up:
src/error.rs	`50.00% <0.00%> (+1.47%)`	:arrow_up:
src/iter.rs	`58.16% <0.00%> (+3.06%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a01bdf0...755bc19. Read the comment docs.

althonos commented 2 years ago

Thanks a bunch! I'll be making a new postrelease to get the wheels on PyPI.

fastobo / fastobo-py

Add aarch64 wheel build support #246

Codecov Report