search

fastred / AHKActionSheet

An alternative to the UIActionSheet inspired by the Spotify app.
MIT License
1.16k stars 130 forks source link

Control flexibility improvement #6

Closed iuriimoz closed 10 years ago

iuriimoz commented 10 years ago

added new button option AHKActionSheetButtonTypeDisabled added gesture disabling

fastred commented 10 years ago

Thanks for sending the pull request! I'm not sure I'll merge it, because I don't want to further complicate the API. Let me think about it for a couple days.

iuriimoz commented 10 years ago

Hello.

As you wish. I don't think that api is complicated at all. This action sheet looks pretty cool, but disabling "cancel gesture" was really crucial for my needs. These additions extends range of possible users.. but this is your control and your choice.

P.S. You have nice blog )

WBR, Iurii Mozharovskyi

19 èþëÿ 2014, â 14:01, Arkadiusz Holko notifications@github.com íàïèñàë(à):

Thanks for sending the pull request! I'm not sure I'll merge it, because I don't want to further complicate the API. Let me think about it for a couple days.

— Reply to this email directly or view it on GitHub.

fastred commented 10 years ago

I merged your commits here: https://github.com/fastred/AHKActionSheet/commit/7cf450bd3dfe0c6c36c541bdfd7b58dc4821dae3 I made some small changes in them. I hope I didn't break anything. I also released version 0.4.0 of the library.

Thanks again for taking the time to prepare the pull request.