search

fastred / SloppySwiper

UINavigationController delegate that allows swipe back gesture to be started from anywhere on the screen (not just from the edge).
MIT License
807 stars 106 forks source link

bug for UITabBarController. #2

Closed xhzengAIB closed 9 years ago

xhzengAIB commented 10 years ago

Hi! @fastred Look this picture: slobug

Jack

fastred commented 10 years ago

I can't reproduce it, and I'm not sure why it happens because toViewController's view is inserted below the current view controller's view: https://github.com/fastred/SloppySwiper/blob/master/Classes/SSWAnimator.m#L48

Maybe there's a bug in SSWAnimator but I'm not seeing it right now.

Can you see if it's happening on the physical device too?

xhzengAIB commented 10 years ago

@fastred Ok! I try it.

xhzengAIB commented 10 years ago

Hi! @fastred I running on iPhone4, this bug appear.

Jack

xhzengAIB commented 10 years ago

@fastred I use this open source(https://github.com/xhzengAIB/MessageDisplayKit) and your open source running on my iPhone4, bug appear.

Jack

xhzengAIB commented 10 years ago

@fastred Translation speed not right and the view layers not right.

fastred commented 10 years ago

Thanks for preparing the example. I tested it out and it seems to me that hidesBottomBarWhenPushed doesn't work with custom transitions (I reported it as rdar://17093531).

Here's what happens if I remove all transforms from animateTransition: in SSWAnimator: 2014-06-02 17_45_11

UITabBar slides in independently of the previous view controller's view animations (or lack of thereof). One way of fixing it would be to change the view controller hierarchy by embedding UITabBarController inside of UINavigationController. With this hierarchy you wouldn't have to use hidesBottomBarWhenPushed: screenshot 2014-06-02 17 52 15

xhzengAIB commented 10 years ago

@fastred Ok! I try it.

fastred commented 10 years ago

I added info about this issue to README in https://github.com/fastred/SloppySwiper/commit/bae450e1fd804c4b4f34453985105b839172dd2d I'm not sure anything else can be done to fix it at the moment.

xhzengAIB commented 10 years ago

hi！you fix the bug for tabbarcontroller insert to navigationcontroller？

fastred commented 10 years ago

No, but as I wrote earlier:

Do you have any ideas how to fix this issue?

xhzengAIB commented 10 years ago

@fastred I think should be provided by the apple API is not enough, may be need to apple's support, to solve this issue further.

Jack

aseemsandhu commented 10 years ago

Any further developments on this issue?

fastred commented 10 years ago

You can work around this issue by changing the view controller hierarchy, as I showed in https://github.com/fastred/SloppySwiper/issues/2#issuecomment-44855103

The radar is still open.

wangyang10 commented 9 years ago

I have written the same interaction effect 5 months ago, and deal with the issue when navigationbar hidden or tabbar hidesBottomBarWhenPushed. my repo https://github.com/wangyang10/CustomPopAnimation

fastred commented 9 years ago

Should be fixed in https://github.com/fastred/SloppySwiper/pull/6

yinnieryou commented 9 years ago

Hey, @fastred I forked this repo and work out this issue. Here is the address of my repo: https://github.com/yinnieryou/SloppySwiper I don't know my solution is suitable for you or not, it works perfect on my project.

sloppyswiper

techabserve commented 7 years ago

Hi. Scrollview not working after push and back to the controller