fastruby / dotenv_validator

This gem check if required env variables are present and its format using the .env and .env.sample files from Dotenv.
https://www.fastruby.io/blog/open-source/introducing-dotenv-validator.html
MIT License
50 stars 4 forks source link

[BUG] Add foreman to docker config described in the README #56

Open fbuys opened 2 years ago

fbuys commented 2 years ago

IMPORTANT: please make sure you ask yourself all intro questions and fill all sections of the template.

Before we start...:

Expected behavior:

Information about how to run dotenv_validator when you use foreman.

Actual behavior:

No informatino about how use dotenv_validator when you use foreman.

Context and environment:

We can update this part of the README: https://github.com/fastruby/dotenv_validator#if-you-use-docker-compose-read-this to explain that it applies to foreman too.

For more context refer to this issue: https://github.com/fastruby/rails-template/issues/23

I will abide by the code of conduct

aisayo commented 2 years ago

@fbuys @arielj I realized there is a discussion on whether it is necessary to add this documentation to the README on issue #23, want to confirm if we still want to move forward with this?

arielj commented 2 years ago

@aisayo this foreman issue is unrelated to the dependency on the dotenv gem, we have to still explain in the readme that foreman (like docker), read the .env file differently than dotenv

etagwerker commented 4 months ago

@arielj The table in the README no longer points to a section of the README in the dotenv project. I assume that README's sections changed and maybe it should now point to: https://github.com/bkeepers/dotenv?tab=readme-ov-file#customizing-rails

etagwerker commented 1 month ago

I think it would be useful to add something to the README that points to this issue: https://github.com/ddollar/foreman/issues/702#issuecomment-1227334155

There is a workaround for people who want to use both dotenv and foreman