Add ruby types support - Githubissues

fastruby / dotenv_validator

This gem check if required env variables are present and its format using the .env and .env.sample files from Dotenv.

https://www.fastruby.io/blog/open-source/introducing-dotenv-validator.html

MIT License

50 stars 4 forks source link

Add ruby types support #61

Closed JuanVqz closed 2 years ago

JuanVqz commented 2 years ago

Closes #8

IMPORTANT: Please read the README before submitting pull requests for this project. Additionally, if your PR closes any open GitHub issues, make sure you include Closes #XXXX

[x] Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading.

Description:

[x] Add Integer, Float, String, Boolean, and UUID types support
[x] Add tests
[x] Fix some comments

I will abide by the code of conduct.

JuanVqz commented 2 years ago

@arielj what about Uuid? should I remove it or add UUID instead of Uuid?

Also Boolean doesn't exist in ruby, is okay that I add Boolean, right?

kindoflew commented 2 years ago

@arielj -- ping for re-review. thanks! :shipit:

arielj commented 2 years ago

@JuanVqz I think it should be UUID since that's the class name in Ruby (also Uuid looks bad, it's UUID or uuid everywhere, not just ruby). I guess we can leave Boolean since it's a really common type that people might expect that option, but I don't have a preference there, strictly speaking it's not a Ruby type but the meaning is so common that it should be ok

JuanVqz commented 2 years ago

Done!

JuanVqz commented 2 years ago

Thank you for your feedback! :t-rex: