Open alekseyl opened 6 years ago
Pull requests are always appreciated. The problem with randomized data, of course, is that you don't get reproducible results. At the very least, the seed should be specified so results could be deterministic, IMHO.
The problem with randomized data, of course, is that you don't get reproducible results.
Randomization must be appropriate to the test, in that case results are reproducible
Hmm this is interesting, actually. Although if we're going to randomize things, I also do believe we'd need things to be averaged out.
Did you test multiple runs of your code, @alekseyl?
Also, if you can, feel free to open a PR and we can continue discussions there.
Hmm this is interesting, actually. Although if we're going to randomize things, I also do believe we'd need things to be averaged out.
Did you test multiple runs of your code, @alekseyl?
Also, if you can, feel free to open a PR and we can continue discussions there.
Hi @mateusdeap, here is the PR for you guys to review and check on your own: https://github.com/fastruby/fast-ruby/pull/216/files
You are doing your test without any randomization and length variety, so results are incorrect completely.
You simply just testing how fast are 'foo' and 'bar' concatenation, and only
Live case scenario looks more like this:
OK
Also you didn't test on multiple string concat, where actually "#{'foo'} #{'bar'} #{'shines'}".