fastruby / fast-ruby

:dash: Writing Fast Ruby :heart_eyes: -- Collect Common Ruby idioms.
https://github.com/fastruby/fast-ruby
5.67k stars 376 forks source link

Method call in a block could compare to `&:method_name` too #201

Open arielj opened 2 years ago

arielj commented 2 years ago

This test https://github.com/fastruby/fast-ruby/blob/master/code/general/block-apply-method.rb is comparing:

def fast
  [1, 2, 3].map { |n| do_something(n) }
end

def slow
  [1, 2, 3].map(&method(:do_something))
end

We could have one more test:

def other
  [1, 2, 3].map(&:do_something)
end

Also, I think the names fast and slow shouldn't be used for the methods, the names should describe what the method does, not which one is faster?

ashwinisukale commented 1 year ago

@arielj I guess name fast and slow just indicate which way is faster. In this case if we should not use &method because its slower.