search

fastruby / fast-ruby

:dash: Writing Fast Ruby :heart_eyes: -- Collect Common Ruby idioms.
https://github.com/fastruby/fast-ruby
5.67k stars 376 forks source link

Migrate from Travis CI to GitHub Actions #203

Closed etagwerker closed 2 years ago

etagwerker commented 2 years ago

Hi there,

This PR fixes #202 and adds sharing as a default for the rake task. Sharing is set up to only run in CI, so that it doesn't run on development environments when people are trying to make a contribution to this project...

Please check it out.

Thanks!

etagwerker commented 2 years ago

@ixti Thanks for your review! I addressed your suggestions and updated my changes. 👍

arielj commented 2 years ago

One more thing I forgot, can you update the README file removing the reference to Travis CI? Maybe link to the Actions index.

etagwerker commented 2 years ago

Just a suggestion but shouldn't be a blocker: maybe rename the workflow to something like Benchmarks and benchmarks.yml, currently it's Ruby CI an the filename is rake.yml.

Sounds good to me.

One question that might be outside of the scope of this PR, I see the benchmarks are shared at ips.fastruby.io, mabye this should happen only if the tests are run on the main branch?

@arielj I like this idea, but this can be a future enhancement. This repo doesn't get a ton of PRs so I'm not worried about sharing it with every PR for now. Once this PR is merged I can create an issue so we don't lose track of this.

One more thing I forgot, can you update the README file removing the reference to Travis CI? Maybe link to the Actions index.

Sure thing, done!

etagwerker commented 2 years ago

@arielj Just merged this PR and added a new issue to address the sharing enhancement: https://github.com/fastruby/fast-ruby/issues/207 👍