fastruby / fast-ruby

:dash: Writing Fast Ruby :heart_eyes: -- Collect Common Ruby idioms.
https://github.com/fastruby/fast-ruby
5.67k stars 376 forks source link

Set the SHARE env variable only if current branch is main #212

Closed arielj closed 1 year ago

arielj commented 2 years ago

This PR changes the setup of the workflow to only set the SHARE env variable if the current branch is main.

I have no way of testing this completely until is merged into main.

I first tried to set either 1 or an empty string to the SHARE variable but it didn't work (bechmarks.ips only checks if the env variable is set, not the value, so an empty var triggers the sharing too).

Instead, I went with the solution from the docs here https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files, making the step that sets the env variable conditional to the branch name.

Fixes https://github.com/fastruby/fast-ruby/issues/207

rishijain commented 1 year ago

the changes lgtm.