fastruby / fast-ruby

:dash: Writing Fast Ruby :heart_eyes: -- Collect Common Ruby idioms.
https://github.com/fastruby/fast-ruby
5.67k stars 376 forks source link

LoadError for "e2mmap" and "active_support/core_ext/string/inflections.rb" #217

Closed wteuber closed 1 year ago

wteuber commented 1 year ago

Hi there,

when running all benchmarks, I found that there are missing dependencies.

I see two options to deal with this:

  1. Add dependencies to Gemfile
  2. Skip benchmark unless s.respond_to?(:constantize) (for active_support string inflections) and defined?(Raise) (for e2mmap)

Thanks a lot.

etagwerker commented 1 year ago

@wteuber thanks for bringing this up. I'd suggest we go with option 1. Could you please submit a PR with this change? Thanks!

wteuber commented 1 year ago

@etagwerker ✅ done - here is the PR: https://github.com/fastruby/fast-ruby/pull/218