Closed wteuber closed 1 year ago
Hi there,
when running all benchmarks, I found that there are missing dependencies.
code/general/constantize-vs-comparison.rb
active_support/core_ext/string/inflections.rb
code/general/raise-vs-e2mmap.rb
e2mmap
I see two options to deal with this:
s.respond_to?(:constantize)
defined?(Raise)
Thanks a lot.
@wteuber thanks for bringing this up. I'd suggest we go with option 1. Could you please submit a PR with this change? Thanks!
@etagwerker ✅ done - here is the PR: https://github.com/fastruby/fast-ruby/pull/218
Hi there,
when running all benchmarks, I found that there are missing dependencies.
code/general/constantize-vs-comparison.rb
requiresactive_support/core_ext/string/inflections.rb
code/general/raise-vs-e2mmap.rb
requirese2mmap
I see two options to deal with this:
s.respond_to?(:constantize)
(for active_support string inflections) anddefined?(Raise)
(for e2mmap)Thanks a lot.