Remove "raise vs E2MM#Raise" benchmark from repository

fastruby / fast-ruby

:dash: Writing Fast Ruby :heart_eyes: -- Collect Common Ruby idioms.

5.67k stars 376 forks source link

Remove "raise vs E2MM#Raise" benchmark from repository #95

Open radarek opened 8 years ago

radarek commented 8 years ago

It's nice that someone found that this library is so slow but I think most Ruby devs don't know that e2mmap even exists (actually I learned about this library from this repo). IMHO it would be better to not tell other developers that it exists. I even grepped all gems from ~/.rbenv/ (more that 2000 gems) and only rdoc & yard gems use it (actually they include file ruby_lex.rb). All other benchmarks are more or less used in a real code but this one is completely impractical.

nateberkopec commented 8 years ago

:+1: I've never heard of it, but I wasn't around when it was merged so I dunno the reasoning.

kbrock commented 6 years ago

:+1: does it make sense to just convert this into a PR - seems easier for the maintainers to just click merge.

also noticed that e2mmap has no readme and last changed in 2013

etagwerker commented 2 years ago

At the moment that particular benchmark is failing (#196) with Ruby 3.0.2, so I went ahead and submitted a PR to remove it from this repo: https://github.com/JuanitoFatas/fast-ruby/pull/197