fastruby / harvesting

Ruby wrapper for the Harvest API v2
MIT License
28 stars 30 forks source link

Get Single Record #14

Closed benphelps closed 5 years ago

benphelps commented 6 years ago

This change adds support for fetching a single record, via methods inherited from Harvesting::Models::Base

Used as such:

harvest = Harvesting::Client.new(access_token: access_token, account_id: account_id)
client = Harvesting::Models::Client.get(7327524, client: harvest)

This is the interface suggest in #5.

lubc commented 5 years ago

Hey @benphelps, did you have a chance to look at @etagwerker 's comment? Thanks!

mscottford commented 5 years ago

@lubc I created #22 to try and address the code review comments so that we can get this one merged.

lthurston commented 5 years ago

I've created #23, which includes everything from #22 plus gets invoices model working for GET and includes the line items.

Thanks everyone for your efforts on this! @lubc or @etagwerker, do you have a sense as to when you can get this merged in?