Projects pagination broken in gem release

fastruby / harvesting

Ruby wrapper for the Harvest API v2

MIT License

28 stars 30 forks source link

Projects pagination broken in gem release #33

Closed jhendley25 closed 5 years ago

jhendley25 commented 5 years ago

Hey Folks! First off, thanks for the awesome gem.

We're working on a small project and ran into an issue while fetching harvest projects - it looks like it's fixed on master but the 0.2.0 release has a bug with the paginated project fetching. I get this error:

NoMethodError: undefined method `projects' for nil:NilClass
/gems/harvesting-0.2.0/lib/harvesting/models/projects.rb:40:in `fetch_next_page'

Just FYI since it's fixed on master.

etagwerker commented 5 years ago

@jhendley25 Thanks for the heads up! I just pushed a new version of the gem: https://rubygems.org/gems/harvesting

You can see all the changes in this version over here: https://github.com/ombulabs/harvesting/blob/master/RELEASE_NOTES.md#version-030---jan-22-2018

Could you confirm that the new version works for you?

jhendley25 commented 5 years ago

Yep that fixed it. Thanks!