Proposal: The `client` keyword is confusing -- Let's fix it

fastruby / harvesting

Ruby wrapper for the Harvest API v2

MIT License

28 stars 30 forks source link

Closed etagwerker closed 4 years ago

etagwerker commented 4 years ago

Hey @mscottford,

The client keyword is confusing because there is a Client model and a Harvest Client (as in API client)

So we should probably rename the client key as harvest_client to avoid confusion.

What do you think?

Thanks, Ernesto

mscottford commented 4 years ago

Eek! I took too long to reply. I think this looks good. Nice to see that confusion get cleared up.