search

fastruby / harvesting

Ruby wrapper for the Harvest API v2
MIT License
28 stars 30 forks source link

Rails support #52

Closed nardonykolyszyn closed 4 years ago

nardonykolyszyn commented 4 years ago

Hi guys! Love your company.

I forked the project and added Rails support by creating a custom generator to ease gem configuration, are you open to receive a new PR? The approach is inspired in Heartcombo devise and simple_form intention.

So the generator looks like this:

$ rails g harvesting:install

Tests are covered too via minitets but I can add rspec support.

bronzdoc commented 4 years ago

Hey @nardonykolyszyn!

Thanks so much for your kind words and taking the time to contribute 🙂

Please submit a PR with your changes and one of us will review it!

nardonykolyszyn commented 4 years ago

Just created a new PR here, however some tests are failing due I replaced instance accessors with class variables accessors. Are you guys willing to change this or definitely you want to keep traditional accessors? If you decide to change them, I can fix existing tests. 🛠

PS: I also kept the possibility to use whether environment variables or Rails initializer file.