fastruby / harvesting

Ruby wrapper for the Harvest API v2
MIT License
28 stars 30 forks source link

Include rails generator #53

Closed nardonykolyszyn closed 4 years ago

nardonykolyszyn commented 4 years ago

Added:

✅ Implement initializer by using template pattern ✅ Add generators testing support for rspec ✅ Add attributes_accessors from active_support ✅ New #setup method for custom configuration

etagwerker commented 4 years ago

@nardonykolyszyn thanks for getting this started!

It seems that you included a bunch of changes that are unrelated to the rails generator. Could you look into that?

Thanks!

etagwerker commented 4 years ago

I don't think it is a good idea to add this much code to have a Rails generator. Setting up the client is quite simple:

Thanks for taking the time for this contribution and sorry for the delay in my response!