search

fastruby / harvesting

Ruby wrapper for the Harvest API v2
MIT License
28 stars 30 forks source link

Feature/code coverage codecov #59

Closed etagwerker closed 4 years ago

etagwerker commented 4 years ago

Hey @mscottford,

This PR adds code coverage support for this project. It will report code coverage metrics to codecov.

Please check it out.

Thanks!

etagwerker commented 4 years ago

I just realized that SimpleCov is not compatible with Ruby 2.4.x, so I guess we have two options:

  1. Drop support for Ruby 2.4.x
  2. Implement some sort of logic to not run code coverage reports in the Ruby 2.4.x Travis CI job

I'm leaning towards (1)

rdormer commented 4 years ago

Given that 2.4 has been EOLed, there isn't much point in continuing support for it. Relevant: https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/