search

fastruby / harvesting

Ruby wrapper for the Harvest API v2
MIT License
28 stars 30 forks source link

update http gem for Ruby 3.0 compatibility #65

Closed timirwin closed 3 years ago

timirwin commented 3 years ago

This isn't my branch or fork, but I did verify it fixes a Ruby 3.0 frozen string literal issue in http 3.3.0.

timirwin commented 3 years ago

Ok, looks like a similar change was already merged in https://github.com/fastruby/harvesting/pull/63

etagwerker commented 3 years ago

@timirwin Thanks for the heads up. What version were you using? Maybe we need to release a new version of this gem.

timirwin commented 3 years ago

@timirwin Thanks for the heads up. What version were you using? Maybe we need to release a new version of this gem.

I was using 0.5.0.

timirwin commented 3 years ago

@etagwerker It would be nice to include @jhendley25 's #64 PR (or something similar) in a new version. I needed both fixes for everything to work [that I'm using] when using Ruby 3.