search

fastruby / next_rails

A toolkit to upgrade your next Rails application
https://www.fastruby.io/blog/upgrade-rails/dual-boot/dual-boot-with-rails-6-0-beta.html?utm_source=github&utm_medium=description&utm_campaign=github&utm_term=next-rails
MIT License
466 stars 28 forks source link

Support ERB syntax in old Ruby versions #100

Closed arielj closed 1 year ago

arielj commented 1 year ago

Description

The bundler report compatibility command didn't work in old ERB version. This PR adds a test that exercises that line and also the fix calling ERB.new with different arguments depending on the ERB version.

Motivation and Context

This issue https://github.com/fastruby/next_rails/issues/99

I think this is the same issue https://github.com/fastruby/next_rails/issues/96

How Has This Been Tested?

Added automated tests, without this change it fails in Ruby 2.3

I will abide by the code of conduct

JuanVqz commented 1 year ago

Could you please add this change to the changelog? Looking good 👍

arielj commented 1 year ago

Could you please add this change to the changelog? Looking good +1

done!

JuanVqz commented 1 year ago

@arielj could you please rebase the main branch? now the CI should work as expected :+1:

mateusdeap commented 1 year ago

Looks good to me, but some of the runs were cancelled, is that expected? @arielj @JuanVqz

arielj commented 1 year ago

Looks good to me, but some of the runs were cancelled, is that expected? @arielj @JuanVqz

CI was broken (cancelling jobs) and it's fixed in the main branch, I have to merge main here and that will fix the tests