search

fastruby / next_rails

A toolkit to upgrade your next Rails application
https://www.fastruby.io/blog/upgrade-rails/dual-boot/dual-boot-with-rails-6-0-beta.html?utm_source=github&utm_medium=description&utm_campaign=github&utm_term=next-rails
MIT License
466 stars 28 forks source link

Add DeprecationTracker support for Rails <= 4 #109

Closed JuanVqz closed 9 months ago

JuanVqz commented 12 months ago

Closes https://github.com/fastruby/next_rails/issues/108

arielj commented 9 months ago

@JuanVqz I think I found the issue why these changes looked weird to me, the error this is solving is only present in next_rails < 1.1.0, but it was already fixed

before 1.1.0 the arguments are NOT optional and that's why it's complaining about, since 1.1.0 the arguments are optional and there's no issue

I think we should close this PR, no need to change anything

JuanVqz commented 9 months ago

@arielj thanks for doing the research on it! sure, I'm closing it.