search

fastruby / next_rails

A toolkit to upgrade your next Rails application
https://www.fastruby.io/blog/upgrade-rails/dual-boot/dual-boot-with-rails-6-0-beta.html?utm_source=github&utm_medium=description&utm_campaign=github&utm_term=next-rails
MIT License
466 stars 28 forks source link

added back the latest_version method #73

Closed rishijain closed 1 year ago

rishijain commented 1 year ago

Description:

Closes #70 and #72.

I noticed that these issues are arising because a method def latest_version was removed. It was removed in this commit https://github.com/fastruby/next_rails/commit/40590042e11978e5765049ab293b3114b490324b

but I can still find instances of this method being used in the code. Hence I have added the method back.

rishijain commented 1 year ago

Seeking @arielj review specifically as well since he removed this method.

rishijain commented 1 year ago

I just realised that this is the fix which was also suggested in https://github.com/fastruby/next_rails/pull/62 pr. Feel free to review one of the PRs and close the other one.

arielj commented 1 year ago

Maybe we should add a test to ensure this is not deleted again?

EDIT: looks like #62 does include a test

rishijain commented 1 year ago

@arielj yes, we can merge #62 and close this one.

rishijain commented 1 year ago

I am going to close this PR in favour of #62 as it have test cases as well.