fastruby / next_rails

A toolkit to upgrade your next Rails application
https://www.fastruby.io/blog/upgrade-rails/dual-boot/dual-boot-with-rails-6-0-beta.html?utm_source=github&utm_medium=description&utm_campaign=github&utm_term=next-rails
MIT License
466 stars 28 forks source link

Adds support to print info for multiple files. #83

Open mateusdeap opened 1 year ago

mateusdeap commented 1 year ago

Description

This is a bit of a 2 for 1:

  1. It adds a new option, --path, so that we can provide a custom path to our deprecation files.
  2. With this option we can also give the deprecations command a file glob. That way it will print out information on the deprecation warnings present in all the files that match that glob.

And that's basically it.

Motivation and Context

The motivation is given on the issue it fixes. Fixes #3.

How Has This Been Tested?

Manually on the command line since the info command is entirely contained in the exe/deprecations script.

I will abide by the code of conduct

rishijain commented 1 year ago

@mateusdeap While I think issue #3 was asking for a way to merge multiple shitlist json files, I think this is a good step in that direction. Since we have the deprecations from all the json files in one place now, we can certainly create a new merge mode which will create a new json file with results merged from shitlist files.

Let me know if I am understanding this all a bit differently.

mateusdeap commented 1 year ago

@etagwerker @rishijain Sorry for the late response. I'll later try to address all of these comments

etagwerker commented 1 year ago

@mateusdeap Sounds good, thank you!