I'll add comments on the PR since it's really big.
I think it would be a good idea to use this branch to try to add this to librarian before merging it in case something is missing.
Main changes:
The gem does not have a User model, it provides a concern to include in the app's user model
It allows using other models not named User with the new config
Added tests updating the dummy app, some controller tests and one integration test
Updated the readme adding more steps
Note:
I added a comment about the link_to not working in the Readme, but a summary: we can't have that in the default template in the gem since it would require rails-ujs to support method: :post in link tags, so it defaults to button_to. I also added a section to override this view to have a customized view with the app's style if needed.
This PR is a bit complex but it adds a lot of things to address https://github.com/fastruby/ombu_labs-auth/issues/7 and https://github.com/fastruby/ombu_labs-auth/issues/5
I'll add comments on the PR since it's really big.
I think it would be a good idea to use this branch to try to add this to librarian before merging it in case something is missing.
Main changes:
Userwith the new configNote:
link_tonot working in the Readme, but a summary: we can't have that in the default template in the gem since it would require rails-ujs to supportmethod: :postin link tags, so it defaults tobutton_to. I also added a section to override this view to have a customized view with the app's style if needed.