fastruby / skunk

A SkunkScore Calculator for Ruby Code -- Find the most complicated code without test coverage!
https://www.fastruby.io/blog/code-quality/intruducing-skunk-stink-score-calculator.html
MIT License
511 stars 29 forks source link

Move console report #103

Closed JuanVqz closed 1 year ago

JuanVqz commented 1 year ago

Related https://github.com/fastruby/skunk/issues/50

Description:

I'm looking forward implementing the HTML report but as first step we need to move the console report away of the status reporter class.

If changes to the behavior are made, clearly describe what changes.

I will abide by the code of conduct.

codecov[bot] commented 1 year ago

Codecov Report

Merging #103 (730c868) into main (84e04ce) will decrease coverage by 4.30%. The diff coverage is 97.61%.

:exclamation: Current head 730c868 differs from pull request most recent head ca0b319. Consider uploading reports for the commit ca0b319 to get more accurate results

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   98.41%   94.11%   -4.30%     
==========================================
  Files          17       18       +1     
  Lines         315      323       +8     
==========================================
- Hits          310      304       -6     
- Misses          5       19      +14     
Impacted Files Coverage Δ
lib/skunk/cli/generators/console_report.rb 97.43% <97.43%> (ø)
lib/skunk/cli/commands/status_reporter.rb 100.00% <100.00%> (+2.50%) :arrow_up:
lib/skunk/cli/commands/status_sharer.rb 68.18% <100.00%> (-29.50%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

JuanVqz commented 1 year ago

Closed in favor of https://github.com/fastruby/skunk/pull/114