fastruby / skunk

A SkunkScore Calculator for Ruby Code -- Find the most complicated code without test coverage!
https://www.fastruby.io/blog/code-quality/intruducing-skunk-stink-score-calculator.html
MIT License
511 stars 29 forks source link

Mimic Rubycritic Folder Structure #112

Closed JuanVqz closed 1 year ago

JuanVqz commented 1 year ago

Description:

Hey, I was starting to move the console report at this pr #103 but things turned red when trying to comprehend what I could take from the rubycritic gem to make things easy in skunk (in terms of generators), so, I went ahead and mimic the same structure we have in that gem, to make it easy to follow and understand

I wonder if I should move the analysed_modules.rb and analyzed_modules_collection.rb inside the core directory as the rubycritic gem has, I didn't do it yet because I think those files are fine having them there. but I can move them to have everything aligned.

I will abide by the code of conduct.

codecov[bot] commented 1 year ago

Codecov Report

Merging #112 (71ec012) into main (84e04ce) will decrease coverage by 0.05%. The diff coverage is 98.41%.

:exclamation: Current head 71ec012 differs from pull request most recent head a6af48a. Consider uploading reports for the commit a6af48a to get more accurate results

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   98.41%   98.37%   -0.05%     
==========================================
  Files          17       17              
  Lines         315      307       -8     
==========================================
- Hits          310      302       -8     
  Misses          5        5              
Impacted Files Coverage Δ
lib/skunk/commands/output.rb 100.00% <ø> (ø)
lib/skunk/commands/status_reporter.rb 97.50% <ø> (ø)
lib/skunk/command_factory.rb 81.81% <81.81%> (ø)
lib/skunk/cli/application.rb 100.00% <100.00%> (ø)
lib/skunk/commands/base.rb 100.00% <100.00%> (ø)
lib/skunk/commands/compare.rb 100.00% <100.00%> (ø)
lib/skunk/commands/compare_score.rb 100.00% <100.00%> (ø)
lib/skunk/commands/default.rb 100.00% <100.00%> (ø)
lib/skunk/commands/help.rb 100.00% <100.00%> (ø)
lib/skunk/commands/shareable.rb 100.00% <100.00%> (ø)
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more