fastruby / skunk

A SkunkScore Calculator for Ruby Code -- Find the most complicated code without test coverage!
https://www.fastruby.io/blog/code-quality/intruducing-skunk-stink-score-calculator.html
MIT License
511 stars 29 forks source link

Extract console report #114

Open JuanVqz opened 1 year ago

JuanVqz commented 1 year ago

IMPORTANT: Please read the README before submitting pull requests for this project. Additionally, if your PR closes any open GitHub issue, make sure you include Closes #XXXX in your comment.

Description:

Will left comments in the files

Clos https://github.com/fastruby/skunk/pull/103

I will abide by the code of conduct.

codecov[bot] commented 1 year ago

Codecov Report

Merging #114 (876e380) into main (f6f63c8) will decrease coverage by 0.07%. The diff coverage is 97.77%.

:exclamation: Current head 876e380 differs from pull request most recent head 9ed172d. Consider uploading reports for the commit 9ed172d to get more accurate results

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   98.37%   98.30%   -0.07%     
==========================================
  Files          17       19       +2     
  Lines         307      354      +47     
==========================================
+ Hits          302      348      +46     
- Misses          5        6       +1     
Files Changed Coverage Δ
lib/skunk/commands/status_reporter.rb 100.00% <ø> (+2.50%) :arrow_up:
lib/skunk/core/scorer.rb 92.85% <92.85%> (ø)
lib/skunk/commands/default.rb 100.00% <100.00%> (ø)
lib/skunk/commands/status_sharer.rb 98.27% <100.00%> (+0.60%) :arrow_up:
lib/skunk/generators/console_report.rb 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

JuanVqz commented 7 months ago

@etagwerker it would be nice if you or a contributor could move this to the final line, it seems close but haven't had the chance to check it, thanks!

etagwerker commented 7 months ago

@JuanVqz Other than fixing the conflict, what else is missing in this PR? There are a lot of changes, so it's not easy to understand what's left...

JuanVqz commented 7 months ago

@JuanVqz Other than fixing the conflict, what else is missing in this PR? There are a lot of changes, so it's not easy to understand what's left...

That is true, I'll find a way to update it and explain what is left, :+1: