search

fastruby / skunk

A SkunkScore Calculator for Ruby Code -- Find the most complicated code without test coverage!
https://www.fastruby.io/blog/code-quality/intruducing-skunk-stink-score-calculator.html
MIT License
505 stars 25 forks source link

[REQUEST] Ruby versions compatibility #67

Closed arielj closed 3 years ago

arielj commented 3 years ago

Describe the feature:

As a User I want to see which version of Skunk I can use for my Ruby version

Problem:

The Ruby version requirement for Skunk at ruby gems is not accurate for older versions at least.

https://rubygems.org/gems/skunk/versions/0.4.2 says Ruby >= 0, but that version depends on reek 5.4.0 which depends on Ruby >= 2.3.0.

Maybe a table of which version of skunk is recommended for each version of ruby is useful.

I will abide by the code of conduct

etagwerker commented 3 years ago

@arielj I think that is a great idea. I'm not sure why Rubygems says that skunk is compatible with Ruby >= 0, the gemspec is pretty clear here: https://github.com/fastruby/skunk/blob/main/skunk.gemspec#L17

Any ideas why Rubygems is misreporting that information, @bronzdoc?

bronzdoc commented 3 years ago

@etagwerker weird idk, I opened an issue https://github.com/rubygems/rubygems.org/issues/2651

sonalkr132 commented 3 years ago

https://rubygems.org/gems/skunk/versions/0.4.2 says Ruby >= 0

The link is for 0.4.2. ruby requirement was added in 0.5.0 https://github.com/fastruby/skunk/commit/cdfc9ff6d1649cbbf0752cb134816ec4ad02b16e

etagwerker commented 3 years ago

@sonalkr132 Thanks for looking into this! 🤦‍♂️

bronzdoc commented 3 years ago

Closing since this is not an issue, we just need to push the latest version to rubygems that contains the ruby requirement