search

fastruby / skunk

A SkunkScore Calculator for Ruby Code -- Find the most complicated code without test coverage!
https://www.fastruby.io/blog/code-quality/intruducing-skunk-stink-score-calculator.html
MIT License
511 stars 29 forks source link

Fixes share bug #69

Closed etagwerker closed 3 years ago

etagwerker commented 3 years ago

Hey,

This PR adds a test to reproduce #68 and a patch to fix it.

I had to re-organize the commands so that all of them live under the same scope.

Please check it out.

Thanks!

codecov[bot] commented 3 years ago

Codecov Report

Merging #69 (6d722f3) into main (e521dd9) will increase coverage by 1.45%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   93.93%   95.39%   +1.45%     
==========================================
  Files          23       23              
  Lines         429      434       +5     
==========================================
+ Hits          403      414      +11     
+ Misses         26       20       -6
Impacted Files Coverage Δ
lib/skunk/cli/commands/status_sharer.rb 97.67% <ø> (-0.06%) :arrow_down:
lib/skunk/cli/commands/compare.rb 100.00% <100.00%> (+13.04%) :arrow_up:
lib/skunk/cli/commands/compare_score.rb 100.00% <100.00%> (ø)
lib/skunk/cli/commands/default.rb 100.00% <100.00%> (ø)
test/lib/skunk/cli/commands/compare_score_test.rb 100.00% <100.00%> (ø)
test/lib/skunk/cli/commands/compare_test.rb 100.00% <100.00%> (ø)
lib/skunk/cli/options/argv.rb 95.23% <0.00%> (+14.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e521dd9...efb67f8. Read the comment docs.