Test skunk with ruby 2.3

[etagwerker]

Hey,

This PR tests skunk with Ruby 2.3. I was curious about skunk's compatibility with that version.

Please check it out.

Thanks!

[codecov[bot]]

Codecov Report

Merging #70 (d6f7636) into main (948e79e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          25       25           
  Lines         462      462           
=======================================
  Hits          454      454           
  Misses          8        8           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 948e79e...d6f7636. Read the comment docs.

[bronzdoc]

Is the plan to support a deprecated ruby version for skunk?

[etagwerker]

@bronzdoc Considering most of our clients at FastRuby.io | Rails Upgrade Services are running a deprecated version of Ruby, yes, I think there would be value in supporting older rubies. Not sure how much time and effort it would take, so this PR is intended to do some research.

[bronzdoc]

@etagwerker the plan is to merge this until the build pass with ruby 2.3? or are we good to go?

[lubc]

@etagwerker Looks like the test-ruby-2-3-x build is failing. I just pushed a blank commit to run the build again (the logs expired in the previous build, and the re-run option was disabled)

Were you planning to add support for ruby 2.3 here? Or do you want me to create an issue for that and close this PR?

[bronzdoc]

@lubc you can run the build with this button:

No need for blank commits

[bronzdoc]

We can have this PR just as the setup of circle ci to run the project against 2.3 and we could fix whatever issues we are having in another PR

[etagwerker]

@bronzdoc I'm not sure it is worth it to support Ruby 2.3.

I was trying to figure out how to get the test suite to pass with that version, but there are a lot of dependencies that won't work with Ruby 2.3:

• SimpleCov
• Reek
• RubyCritic

So at the end of the day, I'm not sure it is worth the effort...

[bronzdoc]

@etagwerker got it, ok. Let's close it, for now, we can revisit it in the future if we believe is worth adding support for ruby 2.3