Closed JuanVqz closed 1 year ago
Merging #97 (40a247b) into main (b74fe97) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 25 25
Lines 462 462
=======================================
Hits 454 454
Misses 8 8
Impacted Files | Coverage Δ | |
---|---|---|
lib/skunk/cli/commands/status_reporter.rb | 97.50% <ø> (ø) |
|
lib/skunk/cli/commands/status_sharer.rb | 97.67% <ø> (ø) |
|
lib/skunk/rubycritic/analysed_module.rb | 100.00% <ø> (ø) |
|
test/lib/skunk/rubycritic/analysed_module_test.rb | 100.00% <ø> (ø) |
|
lib/skunk/cli/options/argv.rb | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
CHANGELOG.md
that links to this PR under the "main (unreleased)" heading.Description:
I wanted to contribute, so, stepped forward cloned it, ran the test suite, and here we go, got a failing test and I spent some time trying to understand it and solve it.
My understanding is that somehow rubycritic changed some core logic and now the Churn class is returning 4 instead of 5, since the
churn_times_cost
depends on thechurn
value it changed as well.I will abide by the code of conduct.