With this PR, it's planned to update the current test routine for the available Fastscape processes.
I started with initial conditions, which include BareRockSurface, NoErosionHistory, FlatSurface, and Escarpment. The former three are relatively straight forward to do. In Escarpment I considered three cases to parametrize:
elevation_left > elevation_right
elevation_left < elevation_right
elevation_left == elevation_right
I'm not sure if more cases should be included, e.g. zero or negative elevation.
Moreover, I don't fully understand what the code following
if scarped_width > 0:
is meant to do, i.e. the full logic behind it. I tried to come up with a proper example but I ended up running into other issues. Because of this, I haven't tested yet the if condition.
Additionally, for testing the FastscapelibContext I supplied a value for ibc since none was given and the test fails otherwise. Do we need to call ibc at one point during the testing? As far as I can see, it's not part of the context dictionary (I might be wrong here).
One more thing, I want to mention. elevation_left has to be a float because of the following line:
With this PR, it's planned to update the current test routine for the available Fastscape processes.
I started with initial conditions, which include
BareRockSurface
,NoErosionHistory
,FlatSurface
, andEscarpment
. The former three are relatively straight forward to do. InEscarpment
I considered three cases toparametrize
:elevation_left
>elevation_right
elevation_left
<elevation_right
elevation_left
==elevation_right
I'm not sure if more cases should be included, e.g. zero or negative elevation. Moreover, I don't fully understand what the code following
is meant to do, i.e. the full logic behind it. I tried to come up with a proper example but I ended up running into other issues. Because of this, I haven't tested yet the
if
condition.Additionally, for testing the
FastscapelibContext
I supplied a value foribc
since none was given and the test fails otherwise. Do we need to callibc
at one point during the testing? As far as I can see, it's not part of thecontext
dictionary (I might be wrong here).One more thing, I want to mention.
elevation_left
has to be afloat
because of the following line:It's probably a good idea, to include an additional check. Otherwise, a
UFuncTypeError
is raised.But maybe you want to talk about it in a separate issue.