search

fastscape-lem / fastscapelib-fortran

A Fortran (+ Python bindings) library of efficient algorithms for landscape evolution modeling
https://fastscape-lem.github.io/fastscapelib-fortran/
GNU General Public License v3.0
23 stars 17 forks source link

Compute catchments after resolving closed depressions #42

Open benbovy opened 3 years ago

benbovy commented 3 years ago

Currently catchment numbers are computed within the find_stack subroutine, which is called before LocalMinima in flow routing routines.

I think that in most cases we want catchment boundaries to rather correspond to the flow route paths obtained after resolving closed depressions.

benbovy commented 3 years ago

Also, having integers (e.g., corresponding to the outlet node index) rather than random float numbers for the catchment ids would make more sense (and yield more stable results).

benbovy commented 3 years ago

One benefit of using random numbers might be that one may easily distinguish adjacent catchments even when using continuous color maps, but arguably this should be addressed by using random, discrete color maps.

LeoZijerveld commented 3 years ago

Thanks for considering this. I would think that the benefits of using a meaningful number (i.e. corresponding to the outlet node) outweighs the plotting benefit you describe in your second comment.