Activate CMake build flags + fix warnings / errors

fastscape-lem / fastscapelib-fortran

A Fortran (+ Python bindings) library of efficient algorithms for landscape evolution modeling

https://fastscape-lem.github.io/fastscapelib-fortran/

GNU General Public License v3.0

23 stars 17 forks source link

Activate CMake build flags + fix warnings / errors #47

Closed benbovy closed 3 years ago

benbovy commented 3 years ago

dialect flags were commented in CMakeLists.txt.

use Fortran 2008 standard
use implicit none everywhere (flag)
set output files (VTK) endianness using flags instead of within the code

benbovy commented 3 years ago

@sebastianwolf I don't think the changes made here would break anything in your workflow, but I'm not 100% sure. Please let me know if you see anything here that could affect how your are using fastscapelib.

sebastianwolf commented 3 years ago

@benbovy this looks good from my side. I read through the changed files and I can't see how these changes affect my workflow. I have been using a custom Makefile (with flags based on your cmake-list), because cmake is not installed on all machines that I have been using. And I am not used to cmake... In case there is a compilation error on my side, I will just update my Makefile with your options. That should be just fine.

benbovy commented 3 years ago

Ok great. Yeah I think that it should still compile without changing anything on your side, as the flags activated here are mainly to enforce a more strict dialect. Except maybe if you use the VTK subroutines here, you'll probably need to add -fconvert=big-endian (gfortran).