search

fastscape-lem / fastscapelib-fortran

A Fortran (+ Python bindings) library of efficient algorithms for landscape evolution modeling
https://fastscape-lem.github.io/fastscapelib-fortran/
GNU General Public License v3.0
23 stars 17 forks source link

Add VTK file that takes a folder path and outputs more fields by default #53

Open Djneu opened 1 year ago

Djneu commented 1 year ago

Hi all, This is a modified VTK file we've been using with the fastscape-aspect coupling which takes a folder path (assuming a separate program has already created this and the VTK folder), and creates VTK files into this that by default show the topography, basement, erosion rate, total erosion, drainage area, and catchment.

Would it be possible to include this file on the main branch? Thank you for your time!

benbovy commented 1 year ago

Hi @Djneu,

Thanks for the PR and sorry for the wait.

Probably a cleaner way to do this would have been to refactor the current VTK routine to make it a bit more flexible, but this would be more work with breaking changes. TBH I'm a bit reluctant adding more functionality since this repository is in maintenance-only mode (https://github.com/fastscape-lem/fastscapelib-fortran/issues/55#issuecomment-1564242506), but if that's something helpful for you I'd be fine doing an exception here.

Djneu commented 1 year ago

Hi @benbovy, no problem and thanks for the reply! In this case I think we will keep a separate branch of this fortran version for the small changes we will make as the eventual plan is to convert the plugin to work with the C++ version.