fastscape-lem / fastscapelib

A C++/Python library of efficient algorithms for landscape evolution modeling
http://fastscapelib.readthedocs.io
GNU General Public License v3.0
36 stars 6 forks source link

Fix benchmarks #152

Closed adriendelsalle closed 6 months ago

adriendelsalle commented 6 months ago

Description

Fix benchmarks by removing benchs already reimplemented in other files:

benbovy commented 6 months ago

Thanks @adriendelsalle, good catch.

Both benchmark_flow_routing.cpp and benchmark_pflood.cpp are remnants of functions that have been either removed from public API or completely removed. Perhaps we can get rid of them (at least benchmark_pflood.cpp as I don't think it provides more than what is already benchmark_sink_resolver.cpp).

adriendelsalle commented 6 months ago

@benbovy my bad, I started fixing the benchs before seing they were already covered by other/newer benchs.. I just pushed the last commit deleting those 2 files