search

fastscape-lem / fastscapelib

A C++/Python library of efficient algorithms for landscape evolution modeling
http://fastscapelib.readthedocs.io
GNU General Public License v3.0
36 stars 6 forks source link

Structured grids and looped boundary conditions #58

Closed benbovy closed 1 year ago

benbovy commented 3 years ago

From https://github.com/fastscape-lem/fastscapelib/pull/51#discussion_r552446908

benbovy commented 3 years ago

We should maybe drop the case of full periodic boundaries for the four borders of a raster grid after #53.

adriendelsalle commented 3 years ago

Hi @benbovy

From the current implementation, we should drop:

Can you confirm ? They don't correspond to any physical representation?

Thanks!

benbovy commented 3 years ago

Yes we can drop those cases!

adriendelsalle commented 3 years ago

At this time, I'm not sure we want to remove cases that may be not useful (because not matching any physical representation) but still, working.

benbovy commented 3 years ago

Yeah, I agree, let's keep them for now.

My only concern is that it might confuse users who don't really know what they are doing, but let's see... (I'd keep this issue open).

benbovy commented 1 year ago

It actually makes sense physically (using inner base level nodes as boundary conditions for flow-based processes). Closing.