search

fastsupply / growl

Automatically exported from code.google.com/p/growl
0 stars 0 forks source link

GrowlTunes hangs after pictd dies #114

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
GrowlTunes, as of 1.2.1b2, asks iTunes for album art as a QuickDraw picture 
(“PICT”).

Since Mac OS X 10.6, AppKit (at least in 64-bit applications, where QuickDraw 
is unavailable) 
hands the job of interpreting PICT to a daemon called “pictd”.

Unfortunately, this daemon sometimes crashes. After that happens, any app that 
requests the 
interpretation of PICT data will hang in waiting for the response.

Original issue reported on code.google.com by prhgr...@gmail.com on 17 Mar 2010 at 8:09

GoogleCodeExporter commented 9 years ago 
The fix should be to request the raw data for the artwork, not the PICT data. 
Nearly all of the time, this will 
return JPEG or PNG data.

This can still fail if a track actually has PICT data for its first artwork. We 
could fortify the fix by filtering the 
artworks by type. Currently, we use the first artwork unconditionally, but we 
could loop over the artworks, 
asking for their types, and only requesting the first one that isn't PICT.

Even that could still fail if a track has nothing but PICT data for its 
artwork, but we can't do anything about 
that.

Original comment by prhgr...@gmail.com on 17 Mar 2010 at 8:16

GoogleCodeExporter commented 9 years ago 
I've applied the fixes locally. I'll test the second part (only accept artworks 
that are not PICT) later today; my 
pictd fell over last night, so I can't use PICT images right now, which means I 
can't test the second part yet (if I 
can at all).

Original comment by prhgr...@gmail.com on 17 Mar 2010 at 9:00

GoogleCodeExporter commented 9 years ago 
Fixed as described above in [1a19b81fa305] and [1a71a675d862].

Original comment by prhgr...@gmail.com on 20 Mar 2010 at 7:06