fastsupply / growl

Automatically exported from code.google.com/p/growl
0 stars 0 forks source link

Update OS-version check in GrowlInstallationPrompt #50

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run an app using Growl-WithInstaller.framework 1.2 on Mac OS X 10.4 through 
10.4.11.

What is the expected output?
No Growl prompt.

What do you see instead?
It'll prompt.

The GrowlInstallationPrompt class does contain an OS-version check, but it's 
out of date: it checks 
for 10.3. We need to check for 10.5 instead. (In fact, we should use Gestalt to 
check for 10.5.8, so 
we can use NSOperationQueue.)

Original issue reported on code.google.com by prhgr...@gmail.com on 22 Oct 2009 at 6:30

GoogleCodeExporter commented 9 years ago
Does http://growl.info/hg/growl-development/rev/fac59330ff0c address this?

Original comment by chrisf.g...@gmail.com on 6 Dec 2009 at 6:13

GoogleCodeExporter commented 9 years ago
No, that makes it not crash apps on launch on Tiger—it has nothing to do with 
the version check, which 
happens at run time. http://growl.info/hg/growl-development/rev/2f99d2f175f4 
does fix this issue, though.

Original comment by prhgr...@gmail.com on 6 Dec 2009 at 7:49