search

fastsupply / growl

Automatically exported from code.google.com/p/growl
0 stars 0 forks source link

GrowlMail version info #72

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:
Patch adds GrowlMail version string to bottom of preferences panel in Mail,
so user can identify version easily.

When reviewing my code changes, please focus on:
Everything ;) I'm new to this game.
Not sure if assignment of growlMailVersion is in correct place.
Value was borrowed from a debug message elsewhere in code.

Original issue reported on code.google.com by I.atent.dead@gmail.com on 2 Dec 2009 at 10:03

Attachments:

GoogleCodeExporter commented 9 years ago 
The short version string (CFBundleShortVersionString) is guaranteed to be the 
human-readable version 
number, as compared to the CFBundleVersion, which may be a build number. For 
example, Safari's short 
version string is "4.0.3", whereas its version (build number) is 6531.9.

We currently set them both to the same value in GrowlMail, but this may not 
last forever. Better to set it to the 
short version string, which will always be right.

The other change I suggest is to not use stringWithFormat: here. The “v” 
prefix may not make sense in all 
languages, so the format string should be localized using NSLocalizedString; 
more to the point, I don't think 
we need to decorate the version number at all. Simply putting the short version 
string, with no modification, 
into the text field should be enough.

Original comment by prhgr...@gmail.com on 2 Dec 2009 at 10:53

GoogleCodeExporter commented 9 years ago 
Can we get a screenshot attached with this change in it?

Original comment by chrisf.g...@gmail.com on 2 Dec 2009 at 11:30

GoogleCodeExporter commented 9 years ago 
okay. how these? :)

Original comment by I.atent.dead@gmail.com on 3 Dec 2009 at 10:56

Attachments:

GoogleCodeExporter commented 9 years ago 
I think that looks fine. As long as it passes code review I'm ok with how it 
looks. Good work :)

Original comment by chrisf.g...@gmail.com on 6 Dec 2009 at 3:39

GoogleCodeExporter commented 9 years ago 
addressed in [4741:17588243781c]

Original comment by rarich...@gmail.com on 6 Dec 2009 at 7:48