Abolish use of bundleWithIdentifier: in the framework

fastsupply / growl

Automatically exported from code.google.com/p/growl

0 stars 0 forks source link

Abolish use of bundleWithIdentifier: in the framework #83

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

iiwas, on the Growl Discuss list, reports that the Growl framework's use of 
bundleWithIdentifier: is 
expensive. We should avoid using bundleWithIdentifier: in the framework.

Notes from Peter:
I'm reasonably sure that the method that calls bundleWithIdentifier:, 
+[GrowlPathUtilities 
growlPrefPaneBundle], is also used in the prefpane. We can't avoid it there, 
since looking up 
prefpanes by path may find the wrong prefpane (someday, if not today), whereas 
bundleWithIdentifier: will always return the right one.

We should make a second method, and remove the bundleWithIdentifier: method 
from the original 
method and move it to the second method, which would call the original method 
if 
bundleWithIdentifier: finds nothing.

Original issue reported on code.google.com by chrisf.g...@gmail.com on 6 Dec 2009 at 1:45

GoogleCodeExporter commented 9 years ago

Original comment by chrisf.g...@gmail.com on 7 Dec 2009 at 2:56

Added labels: Milestone-1.2.2

GoogleCodeExporter commented 9 years ago

Original comment by chrisf.g...@gmail.com on 29 Jul 2010 at 4:42

Added labels: Milestone-2.0

GoogleCodeExporter commented 9 years ago

Speed improvements are always nice. Marking this for 2.0.

Original comment by chrisf.g...@gmail.com on 15 Oct 2010 at 4:58

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Original comment by prhgr...@gmail.com on 28 Mar 2011 at 9:30

GoogleCodeExporter commented 9 years ago

Changing the owner on these to get them out of Peter's queue.

Original comment by chrisf.g...@gmail.com on 15 Aug 2011 at 6:49

GoogleCodeExporter commented 9 years ago

Original comment by ch...@growl.info on 21 May 2012 at 11:14

Changed state: New
Added labels: Product-SDK

GoogleCodeExporter commented 9 years ago

Original comment by ch...@growl.info on 22 May 2012 at 12:35

GoogleCodeExporter commented 9 years ago

Original comment by ch...@growl.info on 9 Oct 2012 at 3:43

Added labels: Milestone-2.0.1, Product-Growl
Removed labels: Milestone-2.0

GoogleCodeExporter commented 9 years ago

addressed in r4887e031bd39

Original comment by rarich...@gmail.com on 19 Oct 2012 at 2:11

Changed state: FixedInSource

GoogleCodeExporter commented 9 years ago

Original comment by ch...@growl.info on 11 Jan 2013 at 6:26

Changed state: Fixed