search

fastyangmh / ImageClassification

MIT License
0 stars 1 forks source link

Class `Predict` parameter error and repeated instantiation in `main.py`. #1

Closed Heegreis closed 2 years ago

Heegreis commented 2 years ago

Why Predict repeated instantiation? https://github.com/fastyangmh/ImageClassification/blob/483e6f8e9131b7a172696d3488036843f0abf5ec/main.py#L21-L23 Maybe edit as following:

        predicter = Predict(project_parameters=project_parameters)
        result = predicter.predict(filepath=project_parameters.root)

and the parameter filepath when call Predict.predict is not match to the definition inputs. https://github.com/fastyangmh/ImageClassification/blob/483e6f8e9131b7a172696d3488036843f0abf5ec/src/predict.py#L30

fastyangmh commented 2 years ago

@Heegreis, I solved the problem, please confirm the PR. If there is no problem, I will merge to the dev branch. Thank you.