search

fat-tire / android_device_bn_encore

59 stars 20 forks source link

Ics ramdisk #30

Closed ryands closed 12 years ago

ryands commented 12 years ago

Change-Id: I3f896c939d585e299695c39016d89c76f48cd4a8

Don't update init.encore.rc for internal (redundant + messes things up)

unforgiven512 commented 12 years ago

I will likely end up reverting this.

I have my reasons as to why it is included. The only thing I am doing with updating the init.encore.rc is sed replacement of the mount lines. I tested it fully, it will only replace the appropriate line. Now, I understand in MOST cases, it is redundant.

But the way the sed replacement is done, it directly replaces the entire mount line. It replaces the line in place, by directly altering the file. There is absolutely no harm (but I do agree -- in most cases, it is redundant) in updating init.encore.rc. If you were to update for SD, then want to do internal after that, you'd have to manually go edit the init.encore.rc back to internal.

I don't see any harm in leaving it how it originally was. I will do some further investigation when I get home, but I will likely end up reverting it.

(Sorry if this made little sense -- running on practically no sleep. Had to drive 11 hours to visit family.)

ryands commented 12 years ago

It also causes people who want to say, mount /system rw, problems when generating the ramdisk image.

fat-tire commented 12 years ago

I've got some changes coming to this script so standby before anyone changes anything..

unforgiven512 commented 12 years ago

Can you go over them with me, by chance? On Dec 5, 2011 8:54 PM, "fat-tire" < reply@reply.github.com> wrote:

I've got some changes coming to this script so standby before anyone changes anything..

Reply to this email directly or view it on GitHub:

https://github.com/fat-tire/android_device_bn_encore/pull/30#issuecomment-3027017

unforgiven512 commented 12 years ago

@ryands -- I can also add a "--systemrw" flag to do that :)

Whatever you think needs done, I can do it. I may re-write it in Perl, just for shits and giggles.

fat-tire commented 12 years ago

Hey I haven't seen you around. If I can't find you soon I'll just push and you can look at it. Shouldn't be too big of a deal.

ryands commented 12 years ago

I like to avoid getting too complex on a simple tool such as this, but one idea could be a "template" of sorts that generates an init.encore.rc on run, but the template could then be customized for different use cases, etc....