search

fat / haunt

A module for creating github issue bots
fat.github.com/haunt
Apache License 2.0
248 stars 20 forks source link

Accidental "spamming" of bootstrap #11

Open andrewdeandrade opened 12 years ago

andrewdeandrade commented 12 years ago

I wasn't totally sure what make haunt did in the twitter bootstrap makefile and accidentally spammed dozens of github issues for the project. I'm guessing there should be some sort of control or confirmation dialog before it is run for the first time on an open project. I didn't expect one of the makefile commands to perform so many actions on github on my behalf that I didn't intend.

reference example: https://github.com/twitter/bootstrap/issues/4550

koenpunt commented 11 years ago

That probably isn't a bug but just ignorance because in the Makefile it states:

# HAUNT GITHUB ISSUES 4 FAT & MDO ONLY (O_O  )

But sure, I did the same, installed haunt, run make haunt and entered my GitHub credentials.

andrewdeandrade commented 11 years ago

It's not a bug, but it is certainly an issue. IMHO the haunt command itself should go ahead and tell you what you are about to do and put a prompt that asks you if you are sure you want to execute the command, requiring you to type out the entire word "yes"

mk-pmb commented 8 years ago

If its "[for] FAT & MDO ONLY" then a whitelist check of the given username might help as well.

Also a hint like "(automated bot message)" at the beginning could help, and that "should include a jsfiddle/jsbin" detection could be improved, then the accidential posts might even be helpful.