search

fat / zoom.js

Medium's Image Zoom for jQuery
https://fat.github.io/zoom.js
MIT License
4.04k stars 331 forks source link

Window size bug #20

Closed nroman closed 9 years ago

nroman commented 9 years ago

If you make the browser's window size less than the minimum size of the image after you try to zoom in the image it would be zoom out

fat commented 9 years ago

heh sorry i dont quite follow - that sentence was a mouthful

brmullikin commented 9 years ago

I think what is meant is that if the image is larger than the viewport then zoom.js will scale the image to the size of the viewport, thus making it smaller.

I noticed this first when having developer tools open on the page (which severely limits the height). I suppose the same would happen with a non-responsive page when the browser is made narrow.

I would think this isn't a bug though, but an expected effect.

nroman commented 9 years ago

Yes, brmullikin answered correctly. Sorry, I had no idea about the user expectations in this case. So if it is as expected - please, close this bug.

Just for instance - the video: https://github.com/nroman/tmp/blob/master/zoomBugWindowSize.wmv?raw=true

From my side as a user I expected to see the bigger size of an image to see the details of it. But if you say zoom.js is working in the way you said I'm ok with it. and this is not a bug.

fat commented 9 years ago

ah yep, this is expected :+1: