search

fat / zoom.js

Medium's Image Zoom for jQuery
https://fat.github.io/zoom.js
MIT License
4.04k stars 332 forks source link

Right click on expanded image #68

Open CliffS opened 8 years ago

CliffS commented 8 years ago

I got complaints from my users that they would expect right-click to work on the image while it's expanded. Currently it simply closes the zoom.

I simply added one line to _clickHandler:

    if (e.which == 3) return

Would you like a PR, do you disagree with the change or would you like me to add it in as an option?

spinningarrow commented 8 years ago

Seems to be working fine, at least on Chrome 48 on OS X. Which browser and OS are you on?

image

CliffS commented 8 years ago

On 01/02/16 13:14, Sahil Bajaj wrote:

Seems to be working fine, at least on Chrome 48 on OS X. Which browser and OS are you on?

Ubuntu 15.10 and Firefox 44.0.

What happens currently is that the right click is seen as a click and causes the enlarged image to close.

Cliff Stanford London: +44 20 0222 1666 Swansea: +44 1792 469 666 Mobile: +44 7973 616 666

spinningarrow commented 8 years ago

Looks like a Firefox issue - I tried it just now and though I see the context menu, the image does zoom out as you described.