search

fatalis / SourceSplit

LiveSplit component for Source engine games
Do What The F*ck You Want To Public License
32 stars 14 forks source link

Removed L4D2 from badExes #4

Closed DigitalVortex92 closed 9 years ago

DigitalVortex92 commented 9 years ago

According to multiple threads, VAC bans are served on a Memory Write basis. Memory read appears to be safe (What SourceSplits does).

So I removed L4D2 as I can confirm that the code does in fact split/pause/start correctly on map changes and loads

fatalis commented 9 years ago

Yeah, but there's no guarantee it will always be like this. I don't want to be held liable if VAC changes how it works in the future. You can just distribute your modded version.

DigitalVortex92 commented 9 years ago

I tried that and CryZe said he doesn't want 2 versions of SourceSplits out there. I can't add it as a split category, so when I do add it as a component, it just clears the game time every map rather than splitting.

CryZe commented 9 years ago

I didn't know that Fatalis doesn't want it due to possible VAC bans. In that case you can just add it to the Auto Splitter XML as a second component. But you should definitely test whether yours even works first.

fatalis commented 9 years ago

If you compile it with the exact version number the git is using (and youll have to update it when i update) and tell people to drop it in their Components folder, everything should work fine. They'll still be able to activate it in the splits editor.

CryZe commented 9 years ago

Oh yeah that works too I guess

fatalis commented 9 years ago

@Cryze There's practically zero chance of the VAC issue ever happening, I'm just covering my ass in case.

DigitalVortex92 commented 9 years ago

That's why when I submitted it to the XML, i put it in the description that it SHOULD be safe.

@fatalis So you want me to compile it with a Different DLL name still correct?

fatalis commented 9 years ago

Just compile it as-is and put it up on dropbox or something. Same name and everything.

DigitalVortex92 commented 9 years ago

And then when you update, I Update, and they download it again and they should be good?

Sounds like a plan to me :)

fatalis commented 9 years ago

Yup, and I have no plans to update.

DigitalVortex92 commented 9 years ago

Alright then xD Thanks!

CryZe commented 9 years ago

What about a checkbox "Activate additional games (Don't blame me if you get banned)"?

DigitalVortex92 commented 9 years ago

I can write that in and merge it if you want Fatalis, That would reduce the work on you other than merging the change. The way I have it now, I added a messagebox that shows a warning saying the info about VAC if left4dead2.exe is selected on the process list when it's closing. Does that sound ok?

Edit: Or rather, when it's selected it gives the warning.

fatalis commented 9 years ago

I might come up with a better solution to all of this in the future, but for now I'm going to leave everything as it is.

DigitalVortex92 commented 9 years ago

So then, in order for LiveSplit to read it i need to add it to the XML, do I just give them the link to my version?

fatalis commented 9 years ago

You don't have to do anything with the XML. Just link your version.

DigitalVortex92 commented 9 years ago

The issue is that LiveSplit doesn't say that Left 4 Dead 2 has an autosplitter associated with it. Therefore they can't configure it in the Splits Editor screen...

fatalis commented 9 years ago

Oh, right. A workaround would be using HL2 in the splits editor then change it to L4D by doing stuff in the layout editor. Or just tell them to load it from the layout editor.

DigitalVortex92 commented 9 years ago

If they load it from the layout editor it doesn't actually split. It just deletes the game time thing that pops up from it and restarts it. Ill have them edit the game from the Layout menu but use HL2 as the game name from the splits editor.

DigitalVortex92 commented 9 years ago

Yup. Game Time is the only thing that runs when it's loaded from the Layout menu. It doesn't split at all, which kinda defeats the purpose of it. And when i set the game as HL2 it doesn't split at all.

fatalis commented 9 years ago

Double check the settings, splits editor and layout editor settings are different.

DigitalVortex92 commented 9 years ago

It works as long as you split at the beginning and end.

fatalis commented 9 years ago

Yeah, each game has to have special support for auto start and end. https://github.com/fatalis/sourcesplit/tree/master/GameSpecific

DigitalVortex92 commented 9 years ago

Yup, I was just working on that. Thanks!

DigitalVortex92 commented 9 years ago

Where do i get a list of offset names to be looking for? As in, where do I find a list of things like this: m_bSuppressingCrosshair. The same thing happens on L4D2 as Portal with the crosshair. All of this stuff is new to me because I didn't wanna touch this stuff at risk of vac a while ago :p

fatalis commented 9 years ago

Game support is really hard to implement if you have no experience with reverse engineering. I suggest just doing start and end manually.